Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-119180: Set the name of the param to __annotate__ to "format" #124730

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Sep 28, 2024

This is what Larry wants, and so it shall be. It's a bit of a hack,
but it's localized and not too bad.

This is what Larry wants, and so it shall be. It's a bit of a hack,
but it's localized and not too bad.
@JelleZijlstra
Copy link
Member Author

cc @larryhastings @carljm

@larryhastings
Copy link
Contributor

larryhastings commented Sep 29, 2024

Please add three tests that use an annotation of format, which is defined in a closure, class scope, and module scope respectively.

@JelleZijlstra
Copy link
Member Author

@larryhastings done.

@larryhastings
Copy link
Contributor

It just hit me--do you mind adding a fourth that fails because format is not defined? I mean, let's cover all our bases here. Let no one accuse us of not doing a thorough job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants