Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-124771: Add the PYTHON_GC_PRESET env var. #124772

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nascheme
Copy link
Member

@nascheme nascheme commented Sep 29, 2024

This is still a WIP. We need to discuss if this is actually a good idea and what the options should be if it is.

There should be a gc.set_preset() function, which is not yet implemented. Also need unit tests for this functionality. The initconfig logic is fairly complex and I'm not sure I did everything correct.


📚 Documentation preview 📚: https://cpython-previews--124772.org.readthedocs.build/

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name PYTHON_GC_PRESET was suggested.

@nascheme
Copy link
Member Author

nascheme commented Oct 1, 2024

The name PYTHON_GC_PRESET was suggested.

Yeah, that's a better name. I've updated the PR. Still need the gc.set_preset() function and some unit tests before this would be ready to merge.

@nascheme nascheme changed the title gh-124771: Add the PYTHON_GC_STRAGEGY env var. gh-124771: Add the PYTHON_GC_PRESET env var. Oct 1, 2024
@vstinner
Copy link
Member

vstinner commented Oct 7, 2024

The PR is a draft. Does it mean that you're not sure if it's a good idea or not? Should it be reviewed or not yet?

@nascheme
Copy link
Member Author

nascheme commented Oct 7, 2024

The code is not yet complete (need gc.set_preset() and gc.get_preset()). Also, I'm hoping for some more discussion on the approach, both from other Python implementations like pypy and from GC experts like Joannah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO-NOT-MERGE interpreter-core (Objects, Python, Grammar, and Parser dirs)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants