Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-126615: Add COMError to ctypes doc. #126686

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

gh-126615: Add COMError to ctypes doc. #126686

wants to merge 10 commits into from

Commits on Nov 16, 2024

  1. add COMError exception to Doc/library/ctypes.rst.

    @junkmd
    junkmd committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    e70aa54 View commit details
    Browse the repository at this point in the history

  2. Add a mention of the difference in exceptions that can be raised.

    @junkmd
    junkmd committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    181f512 View commit details
    Browse the repository at this point in the history

  3. Add a dot to refer to the object within the same module.

    @junkmd
    junkmd committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    857fef5 View commit details
    Browse the repository at this point in the history

  4. Simplify descriptions of attributes.

    @junkmd
    junkmd committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    90fb47f View commit details
    Browse the repository at this point in the history

  5. Align with the docstring defined in the C implementation: 

    "Raised when a COM method call failed."

https://github.com/python/cpython/blob/2313f8421080ceb3343c6f5d291279adea85e073/Modules/_ctypes/_ctypes.c#L5548
    @junkmd
    junkmd committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    1f9d4ee View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
    @junkmd @picnixz
    junkmd and picnixz authored Nov 16, 2024
    Configuration menu
    Copy the full SHA
    b71e310 View commit details
    Browse the repository at this point in the history

  7. Add the dot to make the reflink.

    @junkmd
    junkmd committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    dafb5b2 View commit details
    Browse the repository at this point in the history

  8. Add the availability.

    @junkmd
    junkmd committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    49d5e5f View commit details
    Browse the repository at this point in the history

  9. Create the "Exceptions" section.

    @junkmd
    junkmd committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    1fa159a View commit details
    Browse the repository at this point in the history

  10. Remove the availability directive 

    in order to maintain consistency with other sections.
    @junkmd
    junkmd committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    934c36a View commit details
    Browse the repository at this point in the history