Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-126899: Add **kw to tkinter.Misc.after and tkinter.Misc.after_idle #126900

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Xiaokang2022
Copy link
Contributor

@Xiaokang2022 Xiaokang2022 commented Nov 16, 2024

@graingert
Copy link
Contributor

For this to work you need to make func and ms positional only, which is backwards incompatible

@Xiaokang2022
Copy link
Contributor Author

For this to work you need to make func and ms positional only, which is backwards incompatible

Is making func and ms positional only a must? If not, it will not lead to incompatibilities.

I've found something similar elsewhere in tkinter, but it doesn't enforce that the preceding argument to positional only:

def element_create(self, elementname, etype, *args, **kw):

and

def instate(self, statespec, callback=None, *args, **kw):

@serhiy-storchaka
Copy link
Member

It is not necessary to make other parameters positional only, but this can be considered in future, together with other methods that have var-keyword parameter.

In general, I do not see objections against this change. It does not also look that other Tkinter methods need similar change. But please add tests and a What's New entry.

Doc/whatsnew/3.14.rst Outdated Show resolved Hide resolved
@Xiaokang2022
Copy link
Contributor Author

@serhiy-storchaka PTAL, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants