Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conv Combos with Simulator #6977

Closed
wants to merge 1 commit into from
Closed

Conv Combos with Simulator #6977

wants to merge 1 commit into from
+70 −0

Conversation

skrtskrtfb
Copy link
Contributor

Summary: Conv Combos that fail in simulator

Differential Revision: D66217464

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 20, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6977

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 8d4bc9b with merge base 82763a9 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 20, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66217464

@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@zingo zingo added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Nov 20, 2024
@AdrianLundell
Copy link
Collaborator

Thank you for raising this, we are looking into it!

skrtskrtfb pushed a commit to skrtskrtfb/executorch that referenced this pull request Nov 20, 2024
@facebook-github-bot
Conv Combos with Simulator (pytorch#6977)
af4393b 
Summary:

Conv Combos that fail in simulator

Differential Revision: D66217464
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66217464

@AdrianLundell
Copy link
Collaborator

Seems like the main issue here was missing serialization, please let us know if something else comes up

@freddan80
Copy link
Collaborator

@skrtskrtfb was this PR intended for merging or just to provide a reproducer? If the latter, can it be closed?

@facebook-github-bot
Conv Combos with Simulator (pytorch#6977)
8d4bc9b 
Summary:

Conv Combos that fail in simulator

Differential Revision: D66217464
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66217464

@skrtskrtfb skrtskrtfb closed this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@skrtskrtfb @facebook-github-bot @AdrianLundell @freddan80 @zingo