-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix executorch kv cache incompatibility with to_executorch lowering #7279
Open
dvorjackz
wants to merge
11
commits into
main
Choose a base branch
from
jz/fix-prefill
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+292
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7279
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit e297c9b with merge base 343aa0c (): NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Dec 11, 2024
dvorjackz
force-pushed
the
jz/fix-prefill
branch
2 times, most recently
from
December 16, 2024 21:08
d538d43
to
ee2eb15
Compare
dvorjackz
force-pushed
the
jz/fix-prefill
branch
from
December 16, 2024 21:08
ee2eb15
to
46ea733
Compare
dvorjackz
force-pushed
the
jz/fix-prefill
branch
2 times, most recently
from
December 18, 2024 05:40
5dcb8f7
to
f723fe1
Compare
dvorjackz
force-pushed
the
jz/fix-prefill
branch
from
December 18, 2024 05:41
f723fe1
to
9e68531
Compare
dvorjackz
changed the title
[DRAFT] Fix executorch kv cache incompatibility with to_executorch lowering
Fix executorch kv cache incompatibility with to_executorch lowering
Dec 18, 2024
lucylq
reviewed
Dec 18, 2024
tarun292
reviewed
Dec 19, 2024
tarun292
reviewed
Dec 21, 2024
for pattern in self.patterns: | ||
if pattern in name: | ||
meta["et_init_buffer"] = True | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should raise an exception here if we don't find the buffer.
iseeyuan
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
topic: not user facing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the Llama 3.2 vision text decoder prefill issue by marking the kv cache as an initialized mutable buffer in a custom pass
Test plan