Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Llama3.1 1B HTP to benchmark #7398

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

guangy10
Copy link
Contributor

@guangy10 guangy10 commented Dec 19, 2024

Copy link

pytorch-bot bot commented Dec 19, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7398

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 2c5f9dc with merge base b2a680b (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 19, 2024
@guangy10 guangy10 added module: benchmark Features or issues related to benchmark infra, including the workflow, CI and benchmark apps topic: not user facing labels Dec 19, 2024
@guangy10 guangy10 temporarily deployed to upload-benchmark-results December 19, 2024 04:02 — with GitHub Actions Inactive
@guangy10 guangy10 had a problem deploying to upload-benchmark-results December 19, 2024 04:33 — with GitHub Actions Failure
@guangy10 guangy10 requested review from huydhn and cccclai December 19, 2024 05:00
@guangy10 guangy10 marked this pull request as ready for review December 19, 2024 05:00
@facebook-github-bot
Copy link
Contributor

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@guangy10 guangy10 had a problem deploying to upload-benchmark-results December 19, 2024 05:55 — with GitHub Actions Failure
@guangy10 guangy10 had a problem deploying to upload-benchmark-results December 19, 2024 08:31 — with GitHub Actions Failure
@guangy10 guangy10 had a problem deploying to upload-benchmark-results December 19, 2024 17:32 — with GitHub Actions Failure
@guangy10 guangy10 had a problem deploying to upload-benchmark-results December 19, 2024 18:24 — with GitHub Actions Failure
@guangy10 guangy10 force-pushed the benchmark_llama_htp branch 2 times, most recently from 32a44a8 to e15fd50 Compare December 19, 2024 18:56
@guangy10 guangy10 temporarily deployed to upload-benchmark-results December 19, 2024 19:38 — with GitHub Actions Inactive
@guangy10 guangy10 force-pushed the benchmark_llama_htp branch from e15fd50 to fc3ccb4 Compare December 19, 2024 19:48
@guangy10
Copy link
Contributor Author

The HTP path is expected to take much longer due to calibration. Need to bump up the timeout threshold. I guess there is no harm to bump it up for ALL as most will finish within 30mins anyway.

@facebook-github-bot
Copy link
Contributor

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@guangy10 guangy10 temporarily deployed to upload-benchmark-results December 19, 2024 20:27 — with GitHub Actions Inactive
@guangy10 guangy10 force-pushed the benchmark_llama_htp branch 2 times, most recently from 3287b18 to 0565c7e Compare December 19, 2024 21:36
@guangy10 guangy10 marked this pull request as draft December 19, 2024 21:44
@guangy10 guangy10 temporarily deployed to upload-benchmark-results December 19, 2024 22:20 — with GitHub Actions Inactive
@guangy10 guangy10 force-pushed the benchmark_llama_htp branch from 0565c7e to 361ca85 Compare December 19, 2024 23:46
docker-image: executorch-ubuntu-22.04-qnn-sdk
submodules: 'true'
timeout: 60
timeout: 240
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set to 120 still timed out.

@@ -132,10 +132,10 @@ jobs:
matrix: ${{ fromJson(needs.set-parameters.outputs.benchmark_configs) }}
fail-fast: false
with:
runner: linux.2xlarge.memory
runner: linux.4xlarge.memory
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally on devserver, quantization is taking "INFO:root:Time for quantizing: 1203.9422521591187", but on CI it's 4x slower, bump up to use the 4x runner.

@guangy10 guangy10 had a problem deploying to upload-benchmark-results December 19, 2024 23:52 — with GitHub Actions Failure
@guangy10 guangy10 force-pushed the benchmark_llama_htp branch from 361ca85 to 88a9267 Compare December 20, 2024 00:21
@guangy10 guangy10 temporarily deployed to upload-benchmark-results December 20, 2024 01:04 — with GitHub Actions Inactive
@guangy10 guangy10 had a problem deploying to upload-benchmark-results December 20, 2024 03:20 — with GitHub Actions Failure
@guangy10 guangy10 force-pushed the benchmark_llama_htp branch from 88a9267 to 2c5f9dc Compare December 20, 2024 05:31
@guangy10 guangy10 temporarily deployed to upload-benchmark-results December 20, 2024 06:12 — with GitHub Actions Inactive
@facebook-github-bot
Copy link
Contributor

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@guangy10 guangy10 had a problem deploying to upload-benchmark-results December 20, 2024 08:30 — with GitHub Actions Failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: benchmark Features or issues related to benchmark infra, including the workflow, CI and benchmark apps topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants