Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Llama3.2 CoreML ANE to benchmark #7399

Merged
merged 9 commits into from
Dec 20, 2024
Merged

Add Llama3.2 CoreML ANE to benchmark #7399

merged 9 commits into from
Dec 20, 2024

Conversation

guangy10
Copy link
Contributor

@guangy10 guangy10 commented Dec 19, 2024

Llama3.2 Core ML ANE. Require iOS 18. @huydhn created a new device pool with iOS 18+. We will run the ANE path using this device pool.

Job link: https://github.com/pytorch/executorch/actions/runs/12423590967

Copy link

pytorch-bot bot commented Dec 19, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7399

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 95c6cd7 with merge base 62016d6 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 19, 2024
@guangy10 guangy10 added module: benchmark Features or issues related to benchmark infra, including the workflow, CI and benchmark apps topic: not user facing labels Dec 19, 2024
@guangy10
Copy link
Contributor Author

guangy10 commented Dec 19, 2024

@huydhn We need the ability to specify the OS version together to select devices from the device pool as some configs may require to run on/above certain OS versions. Running Llama3.2 w/ Core ML ANE requires minimal iOS 18.0 for example.

@guangy10 guangy10 marked this pull request as ready for review December 19, 2024 03:31
@facebook-github-bot
Copy link
Contributor

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@guangy10 guangy10 temporarily deployed to upload-benchmark-results December 19, 2024 04:36 — with GitHub Actions Inactive
@guangy10 guangy10 temporarily deployed to upload-benchmark-results December 19, 2024 04:40 — with GitHub Actions Inactive
@guangy10 guangy10 temporarily deployed to upload-benchmark-results December 19, 2024 19:37 — with GitHub Actions Inactive
@metascroy metascroy had a problem deploying to upload-benchmark-results December 19, 2024 21:36 — with GitHub Actions Failure
@metascroy metascroy temporarily deployed to upload-benchmark-results December 19, 2024 22:34 — with GitHub Actions Inactive
@metascroy metascroy temporarily deployed to upload-benchmark-results December 19, 2024 22:41 — with GitHub Actions Inactive
@metascroy metascroy had a problem deploying to upload-benchmark-results December 19, 2024 23:01 — with GitHub Actions Failure
@metascroy metascroy had a problem deploying to upload-benchmark-results December 19, 2024 23:08 — with GitHub Actions Failure
@metascroy metascroy had a problem deploying to upload-benchmark-results December 19, 2024 23:32 — with GitHub Actions Failure
@huydhn
Copy link
Contributor

huydhn commented Dec 20, 2024

@huydhn We need the ability to specify the OS version together to select devices from the device pool as some configs may require to run on/above certain OS versions. Running Llama3.2 w/ Core ML ANE requires minimal iOS 18.0 for example.

It could be done by creating a new device pool. I go ahead and create one ready. You can use arn:aws:devicefarm:us-west-2:308535385114:devicepool:02a2cf0f-6d9b-45ee-ba1a-a086587469e6/12c8b15c-8d03-4e07-950d-0a627e7595b4 for iPhone 15 devices with iOS >= 18.0

@guangy10
Copy link
Contributor Author

Okay, we can see the CoreML ANE is working on iSO 18. Going to use the new device pool for this path

@guangy10 guangy10 force-pushed the benchmark_llama_ane branch 2 times, most recently from 5dbf903 to f44bfe7 Compare December 20, 2024 01:06
@guangy10 guangy10 had a problem deploying to upload-benchmark-results December 20, 2024 01:06 — with GitHub Actions Failure
@guangy10 guangy10 had a problem deploying to upload-benchmark-results December 20, 2024 01:07 — with GitHub Actions Failure
@guangy10 guangy10 force-pushed the benchmark_llama_ane branch from f44bfe7 to 95c6cd7 Compare December 20, 2024 01:08
@facebook-github-bot
Copy link
Contributor

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@guangy10 guangy10 temporarily deployed to upload-benchmark-results December 20, 2024 01:49 — with GitHub Actions Inactive
@guangy10 guangy10 merged commit b2a680b into main Dec 20, 2024
96 of 97 checks passed
@guangy10 guangy10 deleted the benchmark_llama_ane branch December 20, 2024 01:55
@guangy10 guangy10 temporarily deployed to upload-benchmark-results December 20, 2024 02:25 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: benchmark Features or issues related to benchmark infra, including the workflow, CI and benchmark apps topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants