Skip to content

Commit

Permalink
Remove rocm pre-cxx11 abi
Browse files Browse the repository at this point in the history
  • Loading branch information
atalman committed Dec 23, 2024
1 parent 70d8b87 commit ab3acb0
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions tools/scripts/generate_binary_build_matrix.py
Original file line number Diff line number Diff line change
Expand Up @@ -353,10 +353,7 @@ def generate_libtorch_matrix(
if os == WINDOWS:
abi_versions = [RELEASE, DEBUG]
elif os == LINUX:
if with_rocm == ENABLE:
abi_versions = [CXX11_ABI]
else:
abi_versions = [PRE_CXX11_ABI, CXX11_ABI]
abi_versions = [PRE_CXX11_ABI, CXX11_ABI]
elif os in [MACOS_ARM64]:
abi_versions = [CXX11_ABI]
else:
Expand All @@ -378,6 +375,10 @@ def generate_libtorch_matrix(
gpu_arch_type = arch_type(arch_version)
gpu_arch_version = "" if arch_version == CPU else arch_version

# Rocm builds where removed for pre-cxx11 abi
if gpu_arch_type == "rocm" and abi_version == PRE_CXX11_ABI:
continue

desired_cuda = translate_desired_cuda(gpu_arch_type, gpu_arch_version)
devtoolset = abi_version if os != WINDOWS else ""
libtorch_config = abi_version if os == WINDOWS else ""
Expand Down

0 comments on commit ab3acb0

Please sign in to comment.