-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override channel priority on installing. Add check for default channel. #4770
Conversation
@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
Add checkchannel where package is installed test test test test test test test test test test test test Fix lint typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but would be good to add --strict-channel-priority
flag, this one one doesn't even need to run 2nd check
-c defaults \ | ||
"${PACKAGE_NAME}" \ | ||
${CONSTRAINTS} \ | ||
--override-channels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--override-channels | |
--override-channels \ | |
--strict-channel-priority |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok Thank you let me try it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like override works better, strict failed to resolve some of the installs:
https://github.com/pytorch/test-infra/actions/runs/7040631634/job/19161895215?pr=4770
…l. (pytorch#4770) Forward fix for: pytorch#4766 Related to issue: https://github.com/conda/conda/issues/13374 1. Make sure packages are searched in particular order during install. Use override-channel option when installing packages for smoke test: From Conda documentation: https://docs.conda.io/projects/conda/en/latest/user-guide/concepts/channels.html#specifying-channels-when-installing-packages ``` From the command line use --c You may specify multiple channels by passing the argument multiple times. Priority decreases from left to right - the first argument is higher priority than the second. From the command line use --override-channels to only search the specified channel(s), rather than any channels configured in .condarc. ``` 2. Add check for validating that required package is actually installed from required channel
Forward fix for: #4766
Related to issue: conda/conda-libmamba-solver#398
Use override-channel option when installing packages for smoke test:
From Conda documentation:
https://docs.conda.io/projects/conda/en/latest/user-guide/concepts/channels.html#specifying-channels-when-installing-packages