Override node20 compatible glibc for linux x86_64 #5959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
facebook-github-bot
added
the
CLA Signed
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
huydhn
reviewed
Nov 22, 2024
| if: ${{ inputs.architecture == 'x86_64' }} | ||
| run: | | ||
| yum install curl -yyq | ||
| curl -LO https://unofficial-builds.nodejs.org/download/release/v20.9.0/node-v20.9.0-linux-x64-glibc-217.tar.xz |
There was a problem hiding this comment.
If possible, let's host this on our S3 bucket as I'm not sure how reliably this host is, we might end up ddos it
There was a problem hiding this comment.
I think actions/runner#2906 (comment) says that rehosting the file is not what nodejs allows people to do, so it's better to just stick with this link then
huydhn
approved these changes
Nov 22, 2024
thesamesam
added a commit
to thesamesam/meson
that referenced
this pull request
Dec 10, 2024
Do the same as pytorch/test-infra#5959 and download an old nodejs to keep Ubuntu Bionic working. Bug: actions/checkout#1809 Bug: actions/runner#3373
eli-schwartz
pushed a commit
to mesonbuild/meson
that referenced
this pull request
Dec 15, 2024
Do the same as pytorch/test-infra#5959 and download an old nodejs to keep Ubuntu Bionic working. Bug: actions/checkout#1809 Bug: actions/runner#3373 (cherry picked from commit 54cab09)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on this nodejs: https://github.com/nodejs/unofficial-builds/ build compiled with glibc 2.17