Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[disablebot] Fix workflow when run on PR #6096

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

clee2000
Copy link
Contributor

@clee2000 clee2000 commented Dec 20, 2024

We don't have access to the environment at PR time, so we don't have the github token needed for disabling + marking unstable jobs.

At this point, I wonder if it would be better to just make this workflow not run on pull requests at all.


Tested locally with
python .github/scripts/update_disabled_issues.py --token ${GITHUB_TOKEN} --actions disable_tests disable_jobs
to see that both got generated.

Tested in CI by setting ACTIONS="disable_tests disable_jobs" and seeing that both did get generated. The jobs was empty. See the run here https://github.com/pytorch/test-infra/actions/runs/12436552423/job/34724612179

Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
torchci ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 6:33pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 20, 2024
@clee2000 clee2000 marked this pull request as ready for review December 20, 2024 18:35
@clee2000 clee2000 requested a review from a team December 20, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants