Add color font capability to console outputs #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
lint issue is related to new CI rather than pr. |
yifuwang
approved these changes
Feb 24, 2024
train.py
Outdated
| model_name = job_config.model.name | ||
| rank0_log(f"Building {model_name}") | ||
| model_name = job_config.model | ||
| rank0_log(f"{color.yellow} Building {model_name} {color.reset}") |
There was a problem hiding this comment.
Not a blocker, but maybe consider checking if we are being redirected when applying color to avoid '\033[33m' in logs w/ MAST/SLURM.
os.isatty(sys.stdout.fileno())There was a problem hiding this comment.
good point, thanks for flagging this Yifu!
lessw2020
force-pushed
the
add-color-to-console-outputs
branch
from
1198e76 to
5dec536
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current console output is a sea of white.
Added very simple color and style dataclass in utils, so we (or future users) can enable more informative (and fun) console outputs.
current:
after (not necessarily the 'final' color scheme, just showing the difference here):
