Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block on Python 3.13 version #1899

Merged
merged 82 commits into from
Oct 25, 2024
Merged
Changes from all commits
Commits
Show all changes
82 commits
Select commit Hold shift + click to select a range
a8e96cd
Block on Python 3.13 version
joecummings Oct 24, 2024
c80c46b
Fix parsing error for Github workflow
joecummings Oct 24, 2024
f508dfb
Merge
joecummings Oct 24, 2024
e15538b
Try to exclude Python 3.13 from generation matrix
joecummings Oct 24, 2024
2034a8c
Merge
joecummings Oct 24, 2024
b01ef64
Debug code
joecummings Oct 24, 2024
3476d86
Try if
joecummings Oct 24, 2024
3aff075
asdf
joecummings Oct 24, 2024
c882d2d
Asdf
joecummings Oct 24, 2024
9ab1ee1
asdf
joecummings Oct 24, 2024
02349e6
asdf
joecummings Oct 24, 2024
9970131
asdf
joecummings Oct 24, 2024
aeef598
asdf
joecummings Oct 24, 2024
a1e3f08
asdf
joecummings Oct 24, 2024
b0db44f
Why is the matrix only generated 3.9 code
joecummings Oct 25, 2024
5078fa6
Since we can't do this with 3.13, let's simulate with 3.9
joecummings Oct 25, 2024
646794b
Try to access python version through vars
joecummings Oct 25, 2024
61945ce
asdf
joecummings Oct 25, 2024
fbafc42
Asdf
joecummings Oct 25, 2024
6143e7a
Asdf
joecummings Oct 25, 2024
0d38dc3
cmon
joecummings Oct 25, 2024
de23c78
Asdf
joecummings Oct 25, 2024
f46afa9
asdf
joecummings Oct 25, 2024
40b9b9d
Adsf
joecummings Oct 25, 2024
63b1d8e
Asdf
joecummings Oct 25, 2024
88f7252
asdf
joecummings Oct 25, 2024
46abc5e
asdf
joecummings Oct 25, 2024
0e7af34
Asdf
joecummings Oct 25, 2024
62582e1
this is so dumb
joecummings Oct 25, 2024
ffe9053
Asdf
joecummings Oct 25, 2024
2c738b2
Asdf
joecummings Oct 25, 2024
2285fc7
cmon
joecummings Oct 25, 2024
1c6493b
asdf
joecummings Oct 25, 2024
2143a25
asdf
joecummings Oct 25, 2024
ceb0394
why do i need to define a step
joecummings Oct 25, 2024
4791da5
Asdf
joecummings Oct 25, 2024
16b8574
cmon
joecummings Oct 25, 2024
ea563f3
asdf
joecummings Oct 25, 2024
b8e1eae
Asdf
joecummings Oct 25, 2024
f2e8745
Asdf
joecummings Oct 25, 2024
30656bf
asdf
joecummings Oct 25, 2024
62dc3fe
Asdf
joecummings Oct 25, 2024
e9a1e11
adsf
joecummings Oct 25, 2024
19027b7
Asdf
joecummings Oct 25, 2024
d47a4fd
asdf
joecummings Oct 25, 2024
6cd0fda
ASdf
joecummings Oct 25, 2024
3d06720
asdf
joecummings Oct 25, 2024
49ca684
?
joecummings Oct 25, 2024
a0f4097
asdF
joecummings Oct 25, 2024
236a73b
ASdf
joecummings Oct 25, 2024
4506799
Asdf
joecummings Oct 25, 2024
6b146d2
Asdf
joecummings Oct 25, 2024
b7c3c47
this one
joecummings Oct 25, 2024
eb847a9
adsF
joecummings Oct 25, 2024
6294249
asdf
joecummings Oct 25, 2024
754b56e
?
joecummings Oct 25, 2024
79b7b5b
Adf
joecummings Oct 25, 2024
64e68c0
Asdf
joecummings Oct 25, 2024
9cc7588
remove space
joecummings Oct 25, 2024
0ec9383
ASdf
joecummings Oct 25, 2024
e1605a0
Asdf
joecummings Oct 25, 2024
9dd2241
asdf
joecummings Oct 25, 2024
e62b51e
Asd
joecummings Oct 25, 2024
0f42fec
ASdf
joecummings Oct 25, 2024
cf25b88
adsf
joecummings Oct 25, 2024
08850dc
asdf
joecummings Oct 25, 2024
a3974c6
asdf
joecummings Oct 25, 2024
424996f
Asd
joecummings Oct 25, 2024
7137244
asf
joecummings Oct 25, 2024
d0b7ae4
Asdf
joecummings Oct 25, 2024
3743f36
ASdf
joecummings Oct 25, 2024
b4f6c3b
Asdf
joecummings Oct 25, 2024
ba57d20
Asdf
joecummings Oct 25, 2024
4b53db0
asdf
joecummings Oct 25, 2024
2d028bb
Asdf
joecummings Oct 25, 2024
4714638
asdf
joecummings Oct 25, 2024
4c5d962
Asdf
joecummings Oct 25, 2024
1f508e4
Asdf
joecummings Oct 25, 2024
d5ec7a6
Asdf
joecummings Oct 25, 2024
cce7202
Asdf
joecummings Oct 25, 2024
6cc384e
Asdf
joecummings Oct 25, 2024
ffcf4f1
Asdf
joecummings Oct 25, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 31 additions & 3 deletions .github/workflows/build_linux_wheels.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,18 +27,46 @@ jobs:
with-cuda: enable
with-rocm: enable
build-python-only: enable
build:
# TODO: Remove `filter-python-version` after PyArrow releases v18
filter-python-versions:
needs: generate-matrix
runs-on: ubuntu-latest
outputs:
matrix: ${{ steps.set-matrix.outputs.matrix }}
steps:
- name: Filter matrix to exclude Python 3.13
id: set-matrix
shell: python
env:
input-matrix: ${{ needs.generate-matrix.outputs.matrix }}
run: |
import os
import json

# Grab environment variables
input_matrix = json.loads(os.environ["input-matrix"])
github_output_file = os.environ["GITHUB_OUTPUT"]

# Filter out any builds for 3.13
filtered_matrix = {"include": []}
for build in input_matrix["include"]:
if build["python_version"] != "3.13":
filtered_matrix["include"].append(build)

# Write the new matrix to the default outputs file
with open(github_output_file, "w") as handle:
handle.write(f"matrix={json.dumps(filtered_matrix)}")
Comment on lines +31 to +58
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome

build:
needs: filter-python-versions
name: ${{ matrix.repository }}
uses: pytorch/test-infra/.github/workflows/build_wheels_linux.yml@main
if: ${{ needs.generate-matrix.outputs.matrix.python_version }} != '3.13'
strategy:
fail-fast: false
with:
repository: pytorch/torchtune
ref: ""
package-name: torchtune
build-matrix: ${{ needs.generate-matrix.outputs.matrix }}
build-matrix: ${{ needs.filter-python-versions.outputs.matrix }}
pre-script: .github/scripts/pre_build_script.sh
trigger-event: ${{ github.event_name }}
build-platform: 'python-build-package'
Expand Down
Loading