-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flux Autoencoder #2098
base: main
Are you sure you want to change the base?
Flux Autoencoder #2098
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2098
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit aa8b751 with merge base 32e265d (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
from torchtune.models.flux._autoencoder import FluxAutoencoder | ||
|
||
|
||
def flux_autoencoder() -> FluxAutoencoder: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a model builder or component builder?
Also, should it be named flux_v1_autoencoder
, anticipating future flux versions? Or just flux_autoencoder
, anticipating that the autoencoder part probably won't change in the next version?
Context
What is the purpose of this PR? Is it to
Please link to any issues this PR addresses.
Changelog
What are the changes made in this PR?
Test plan
Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.
pre-commit install
)pytest tests
pytest tests -m integration_test
Parity: 3.36e-5
Speed: ~10% faster
Mnimal testing code:
UX
If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example