Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port sample input smoke test #7962

Merged
merged 32 commits into from
Sep 28, 2023
Merged

port sample input smoke test #7962

merged 32 commits into from
Sep 28, 2023

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Sep 14, 2023 •
edited by pytorch-bot bot
Loading

Builds on top of #7954. I'll rebase after that is merged.

cc @vfdev-5

pmeier added 20 commits September 11, 2023 11:00
@pmeier
port tests for F.equalize and transforms.RandomEqualize
348231d
@pmeier
port tests for F.uniform_temporal_subsample and transforms.UniformTem…
7882863 
…poralSubsample
@pmeier
port tests for F.normalize and transforms.Normalize
9b5b7c4
@pmeier
cleanup
c69eb28
@pmeier
port tests for F.clamp_bounding_boxes and transforms.ClampBoundingBoxes
0a6413a
@pmeier
fix normalize tests
227ca27
@pmeier
port tests for F.invert and transforms.RandomInvert
734d0b7
@pmeier
add new tests for F.posterize and transforms.RandomPosterize
845ac36
@pmeier
add new tests for F.solarize and transforms.RandomSolarize
472ec15
@pmeier
add new tests for F.autocontrast and transforms.RandomAutocontrast
41cfdad
@pmeier
add new tests for F.adjust_sharpness and transforms.RandomAdjustSharp…
40f21b2 
…ness
@pmeier
add new tests for F.adjust_contrast
635c2c4
@pmeier
add new tests for F.adjust_gamma
257d0f4
@pmeier
add new tests for F.adjust_hue
c959590
@pmeier
add new tests for F.adjust_saturation
8cd9fdf
@pmeier
cleanup
555d44a
@pmeier
fix normalize
0683b1c
@pmeier
add tests for five / ten crop
01992d3
@pmeier
cleanup
775e5ec
@pmeier
port sample input smoke test
7b1ef58
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 14, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7962

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 5 Unrelated Failures

As of commit 99e5506 with merge base f33e387 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pmeier pmeier marked this pull request as ready for review September 28, 2023 08:50
@pmeier
Copy link
Collaborator Author

pmeier commented Sep 28, 2023 •
edited
Loading

If we merge #8001 before this one, we can completely get rid of the old test here.

@NicolasHug
Copy link
Member

Sorry about the commit and revert, I was on the wrong branch

NicolasHug
NicolasHug approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @pmeier

test/test_transforms_v2_refactored.py Outdated Show resolved Hide resolved
@pmeier
Copy link
Collaborator Author

pmeier commented Sep 28, 2023

Some benchmarks:

  • main:

    $ pytest test/test_transforms_v2.py::TestSmoke::test_common test/test_transforms_v2_refactored.py
[...]
=== 7928 passed, 34 skipped, 96 warnings in 19.48s ===

  • PR:

    $ pytest test/test_transforms_v2_refactored.py
========= 6260 passed, 34 skipped in 16.01s ==========

Although we now test multiple configurations per transform, we ultimately end up (insignificantly on our scales) faster than before, because we removed some duplication between the legacy and current tests as well as doing some refactoring that was not possible in the legacy tests.

@pmeier pmeier merged commit 3da8658 into pytorch:main Sep 28, 2023
57 of 63 checks passed
@pmeier pmeier deleted the transform-sample-test branch September 28, 2023 11:21
@github-actions
Copy link

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Oct 30, 2023
@NicolasHug @facebook-github-bot
[fbsync] port sample input smoke test (#7962)
e442302 
Summary: Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>

Reviewed By: vmoens

Differential Revision: D50789108

fbshipit-source-id: cb38c29356d6ffdba86819bc65b44d2081833d28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
cla signed module: tests module: transforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmeier @NicolasHug @facebook-github-bot