Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved RandomShortestSize Functionality #8684

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

MalumaDev
Copy link

Implement integer support for RandomShortestSize: randomly select a size between the provided integer minimum and the minimum of width and height

Implement integer support for RandomShortestSize: randomly select a size between the provided integer minimum and the minimum of width and height
Copy link

pytorch-bot bot commented Oct 15, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8684

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link

Hi @MalumaDev!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@NicolasHug
Copy link
Member

Thanks for the RP @MalumaDev . Can you share more details - why is this something you need?

@MalumaDev
Copy link
Author

The current behavior, where passing an integer results in the same transformation, is counterintuitive and inconsistent with the Random element of the function name. By introducing integer support, we can achieve more flexible and versatile image resizing based on random dimensions within the specified range.

Expected Behavior:
Integer Input: Passing an integer min_size will result in a random size selected between min_size and the minimum of width and height. Retaining the existing behavior, passing an array [min_size, min_size] will continue to specify a fixed minimum size for both dimensions.

In this way, it provides more control over image resizing by allowing for random variations within a defined range.
Moreover, aligns the behavior with the function's name, ensuring that random selection is indeed applied when using an integer input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants