Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify dependencies in pyproject.toml #1

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Conversation

kevinsung
Copy link
Collaborator

  • First commit edits tox.ini not to install dependencies explicitly, to make sure CI catches this bug

@kevinsung kevinsung marked this pull request as ready for review September 9, 2024 14:16
Copy link
Collaborator

@nkanazawa1989 nkanazawa1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching up the bug and the quick fix. I didn't check install in the clean venv...

@nkanazawa1989 nkanazawa1989 merged commit 448a08c into main Sep 9, 2024
8 checks passed
@nkanazawa1989 nkanazawa1989 deleted the dependencies branch September 9, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants