Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Add DE80 PCB #24439

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

[Keyboard] Add DE80 PCB #24439

wants to merge 11 commits into from
+1,031 −0

Conversation

Deemen17
Copy link
Contributor

Description

Add QMK support for DE80 PCB

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

dunk2k
dunk2k suggested changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@dunk2k dunk2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

layout changes

keyboards/deemen17/de80/keyboard.json Show resolved Hide resolved
keyboards/deemen17/de80/keyboard.json Outdated Show resolved Hide resolved
keyboards/deemen17/de80/keyboard.json Outdated Show resolved Hide resolved
Deemen17 and others added 3 commits September 27, 2024 00:30
@Deemen17 @dunk2k
Update keyboards/deemen17/de80/keyboard.json
c55f589 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@Deemen17 @dunk2k
Update keyboards/deemen17/de80/keyboard.json
a70d5c5 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@Deemen17 @dunk2k
Update keyboards/deemen17/de80/keyboard.json
19572d9 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@Deemen17
Copy link
Contributor Author

Deemen17 commented Sep 26, 2024 •
edited
Loading

@dunk2k thanks for your suggestion.

zvecr
zvecr requested changes Sep 26, 2024
View reviewed changes
keyboards/deemen17/de80/keyboard.json Outdated Show resolved Hide resolved
keyboards/deemen17/de80/readme.md Outdated Show resolved Hide resolved
keyboards/deemen17/de80/readme.md Outdated Show resolved Hide resolved
Deemen17 and others added 3 commits September 27, 2024 01:23
@Deemen17 @zvecr
Update keyboards/deemen17/de80/keyboard.json
ce9ee74 
Co-authored-by: Joel Challis <git@zvecr.com>
@Deemen17 @zvecr
Update keyboards/deemen17/de80/readme.md
9cb78a6 
Co-authored-by: Joel Challis <git@zvecr.com>
@Deemen17 @zvecr
Update keyboards/deemen17/de80/readme.md
94bf2d7 
Co-authored-by: Joel Challis <git@zvecr.com>
@Deemen17
Copy link
Contributor Author

@zvecr thanks for your suggestion.

@drashna drashna requested a review from a team September 26, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@zvecr zvecr Awaiting requested review from zvecr

@dunk2k dunk2k Awaiting requested review from dunk2k

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Deemen17 @drashna @fauxpark @zvecr @dunk2k