Add Model-B keyboard #24681
Open
Add Model-B keyboard #24681
+657
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waffle87
requested changes
Dec 6, 2024
waffle87
requested changes
Dec 6, 2024
Comment on lines
19
to
24
| #define MTNS 0 | ||
| #define INFO 1 | ||
| #define LOGO 2 | ||
| #define MEW 3 | ||
| #define CEL 4 | ||
| #define RAY 5 |
There was a problem hiding this comment.
Suggested change
| #define MTNS 0 | |
| #define INFO 1 | |
| #define LOGO 2 | |
| #define MEW 3 | |
| #define CEL 4 | |
| #define RAY 5 | |
| enum oled_modes { | |
| MTNS, INFO, LOGO, MEW, CEL, RAY | |
| }; | |
| } | ||
|
|
||
| // run this whenever the oled needs to update | ||
| bool oled_task_user(void) { |
There was a problem hiding this comment.
Suggested change
| bool oled_task_user(void) { | |
| bool oled_task_kb(void) { | |
| if (!oled_task_user()) { | |
| return false; | |
| } |
Comment on lines
550
to
554
|
|
||
| // what happens on sleep/power down | ||
| void suspend_power_down_user(void) { | ||
| oled_off(); | ||
| } |
There was a problem hiding this comment.
This is handled internally.
Suggested change
| // what happens on sleep/power down | |
| void suspend_power_down_user(void) { | |
| oled_off(); | |
| } |
| } | ||
|
|
||
| // run this on boot/reset | ||
| bool shutdown_user(bool jump_to_bootloader) { |
There was a problem hiding this comment.
Suggested change
| bool shutdown_user(bool jump_to_bootloader) { | |
| bool shutdown_kb(bool jump_to_bootloader) { | |
| if (!shutdown_user(jump_to_bootloader) { | |
| return false; | |
| } |
| } | ||
|
|
||
| // change depending on if OLED_MOD is pressed | ||
| bool process_record_user(uint16_t keycode, keyrecord_t *record) { |
There was a problem hiding this comment.
Suggested change
| bool process_record_user(uint16_t keycode, keyrecord_t *record) { | |
| bool process_record_kb(uint16_t keycode, keyrecord_t *record) { | |
| if (!process_record_user(keycode, record)) { | |
| return false; | |
| } |
drashna
requested changes
Dec 8, 2024
drashna
reviewed
Dec 9, 2024
Comment on lines
272
to
282
| switch (get_highest_layer(layer_state)) { | ||
| case 0: | ||
| oled_invert(false); | ||
| break; | ||
| case 1: | ||
| oled_invert(true); | ||
| break; | ||
| default: | ||
| oled_invert(false); | ||
| break; | ||
| } |
There was a problem hiding this comment.
For most of these switches, you don't need to explicitly define each case. Eg, since case 0 and default are the same, you can specify just case 1 and default. Case 0 will be covered by "default", and you have less code.
This isn't a required change, just a suggestion.
drashna
approved these changes
Dec 9, 2024
|
|
||
| void eeconfig_init_kb(void) { | ||
| keyboard_config.raw = 0; | ||
| keyboard_config.display_mode_saved = 2; |
There was a problem hiding this comment.
I think you wanted info as the default? So this is probably from my suggestion.
Suggested change
| keyboard_config.display_mode_saved = 2; | |
| keyboard_config.display_mode_saved = INFO; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addition of Model-B, a 75% keyboard. Supports SSD1306 displays and rotary encoders. Six sample screens are baked in for simplicity.
Types of Changes
Issues Fixed or Closed by This PR
Checklist