Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export layer names into json when cli arg is set #24722

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dawosch
Copy link

@dawosch dawosch commented Dec 16, 2024

Description

You can define layer names by enum. When you want to convert your keymap.c file to json with the --no-cpp flag the layer names will be used within your keycodes.
But then you don't know what layer name points to what layer.

With the new --export-layer-names the layer names will be exported under the layer_names attribute within the json file.
Then the indices will point to the corresponding layer.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

24570

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added python cli qmk cli command labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli qmk cli command python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant