Better bans #230
Better bans #230
Conversation
Instead of using a fire-and-forget goroutine, time-based banning work with additional ban data.
main.go
Outdated
| Log.Println("Rejected " + u.Name + " [" + host + "] (banned)") | ||
| u.writeln(Devbot, "**You are banned**. If you feel this was a mistake, please reach out to the server admin. Include the following information: [ID "+u.id+"]") | ||
| if banInfo.UseTime { | ||
| u.writeln(Devbot, "You will be unbaned on "+banInfo.UnbanTime.Format(time.RFC3339)) |
There was a problem hiding this comment.
use a duration here instead of an absolute time
There was a problem hiding this comment.
It looks like that:
devbot: You will be unbaned in 41 days, 15 hours, 56 minutes, and 8 seconds.
or like that:
devbot: You will be unbaned in 13 seconds.
There was a problem hiding this comment.
It's quite verbose. Which could be fine. But we do also have a pretty duration printer here: https://github.com/Arkaeriit/devzat/blob/c98c58e03fd3703f5d500424e886e5f06fe0768d/util.go#L420
what do you think?
There was a problem hiding this comment.
Ho right, I didn't remember this function. printPrettyDuration is not very suitable for duration longer than a day, so not great for bans.
But maybe we can merge printPrettyDuration and formatDuration to prevent code duplication.
I'll make a proposition of it.
There was a problem hiding this comment.
I went with full unit names. So it changes the way the relative time display is. If you don't like it, I will go back to units symbols.
There was a problem hiding this comment.
I see what you mean. maybe it's better to keep it short but add ability to display days using the unit 'd'
There was a problem hiding this comment.
I reverted back to using 1 letter units with no space between the numeric value and the unit.
There was a problem hiding this comment.
It looks like that now:
It's now in the format '9d 4h 3m'.
This makes it easier to remember which key is which.
|
I added an additional feature of storing names in the DB and displaying them when doing |
This PR adds the following improvement related to bans: