-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try adding back RcppArmadillo #78
Conversation
I fixed linking to RcppArmadillo and Github actions. It passes all the checks. The TBB issue is probably unrelated to changes in this PR. |
It passes the checks but that's against the CRAN version of 4.0.2. With 4.1.0 installed locally, I still get:
|
It compiles with quanteda v4.1.0 on my Windows and Linux. I think the linker cannot find the library on your Mac because we are not using autoconf in this package. TBB flag is inserted based on quanteda's installation. https://github.com/quanteda/quanteda.textstats/blob/master/inst/libtbb.R In quanteda, the result |
(base) 192:quanteda.textstats kbenoit$ pkg-config --libs tbb
-L/opt/homebrew/Cellar/tbb/2021.13.0/lib -ltbb |
Does it build if you add If so, we could change https://github.com/quanteda/quanteda.textstats/blob/master/inst/libtbb.R to
|
@koheiw this branch needs to address how to get this package working with the quanteda v4.1.0 that broke it.
With quanteda 4.1.0 installed, the package fails to build: