New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix traitlets warnings to use trait.tag() for metadata #265

Open

ankostis wants to merge 1 commit into quantopian:master from ankostis:fix-traitlets-tag-warns

ankostis commented Jul 22, 2019

Since traitlets-4.1 metadata must not be given to the constructor but should use the tag() method after constructing the trait.

This PR is a cure for these warnings:

fixtures
python3.7/site-packages/qgrid/grid.py:573: DeprecationWarning: metadata {'sync': True} was set from the constructor. With traitlets 4.1, metadata should be set using the .tag() method, e.g., Int().tag(key1='value1', key2='value2')

ankostis force-pushed the fix-traitlets-tag-warns branch from 6884b17 to 919b7cc Compare

July 22, 2019 21:33


          fix: metadata in trait-cstros deprecated since traitlets-4.1

dfb485b

ankostis force-pushed the fix-traitlets-tag-warns branch from 919b7cc to dfb485b Compare

July 22, 2019 21:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet