Add skeleton classes Chess and Move #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstrain115
reviewed
Oct 9, 2023
|
|
||
| def game_over(self) -> int: | ||
| """ | ||
| Checks if the game is over. |
There was a problem hiding this comment.
nit: Usually you put the first line with the triple quotes. This usually looks better in the IDE.
"""Checks if the game is over.
There was a problem hiding this comment.
Thanks Doug. It's fixed.
Currently the pytest fails with error:
E ModuleNotFoundError: No module named 'mock'
, while locally I installed package mock and all tests pass. How may I install this module in the online repository?
dstrain115
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial version of class QuantumChineseChess, which
Add initial version of file move, which