[Quantum RPG] allow action selections to be modified #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a function to get multiple user inputs, each with its own prompt function. Once all inputs have been collected, user gets a chance to confirm selection by providing empty input (press enter) or enter "r" to select again.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
- fixed type annotations to support python 3.9 - fixed remaining broken tests - reformatted changed files
|
other than the unrelated lint errors (fixed in a different PR) this is ready to go. |
solodov
changed the title
dstrain115
reviewed
Mar 8, 2024
| while True: | ||
| inputs = [p() for p in prompts] | ||
| print("[enter]) Confirm selection.", file=file) | ||
| print("r) Select again.", file=file) |
There was a problem hiding this comment.
Maybe we could change this to "Redo selection" so that the choice of 'r' is more obvious?
| """ | ||
| while True: | ||
| inputs = [p() for p in prompts] | ||
| print("[enter]) Confirm selection.", file=file) |
There was a problem hiding this comment.
I am conflicted about making the user do an extra prompt at the end for every action. Let's discuss at the next unitary meeting.
dstrain115
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a function to get multiple user inputs, each with its own prompt function. Once all inputs have been collected, user gets a chance to confirm selection by providing empty input (press enter) or enter "r" to select again.