-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a workflow for linting with Vale #29477
Conversation
c29e492
to
95a94cc
Compare
da92d73
to
692b565
Compare
Thanks @gsmet. I reviewed and replicated the Vale configuration in this PR on my sandbox and see the same behaviour. I will keep digging and testing. It might be a reviewdog v3 issue... I'll ask about this in the vale-at-red-hat community slack channel, in case this is a known issue. I really like your label idea. What about the following: Thanks |
@michelle-purcell I created the label |
@gsmet : Thank you. Perfect 💯 I will add information to the quarkus contributor docs to explain what to do when your PR is littered with errors, warnings, or suggestions that are incorrect or misleading. |
@gsmet - According to the Vale docs ⬇️ and issue Action fails even if fail_on_error is false #89, |
Let's make progress on this even if the situation is not perfect on the Vale side. |
Here is the CI setup for Vale.
From what I can see, with
fail_on_error: false
, the build still fails if Vale complains about something. I think it's probably not a big deal as it's probably a good idea to make people aware of it so that we can fine tune the config.I'm wondering if it could be useful to ping someone from the doc team (Michelle) for failing Vale workflows? At least once we are confident about the setup? Let me know if you think it has value, I can probably do something about it.
Keeping it as a draft for now as I would like to set up the label we talked about with @michelle-purcell today and send an email to the list before actually enabling it.
Fixes #29103