Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): xs breakpoint (fix: #16903) #16972

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ShlomoCode
Copy link
Contributor

@ShlomoCode ShlomoCode commented Mar 6, 2024

Fixing the documents to the breakpoint that is actually used
closed #16903

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:

@ShlomoCode ShlomoCode changed the title fix(docs): xs breakpoint max (https://github.com/quasarframework/quasar/issues/16903) fix(docs): xs breakpoint Mar 6, 2024
@ShlomoCode ShlomoCode changed the title fix(docs): xs breakpoint fix(docs): xs breakpoint (fix: #16903) Mar 6, 2024
@ShlomoCode
Copy link
Contributor Author

ShlomoCode commented Mar 6, 2024

On second thought, it might be confusing
Maybe you should leave .99 and add the information that in practice it is .98 for technical reasons as a tip?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breakpoint for xs is different in documentation vs. practice
1 participant