Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ... checking logic for 3e expect_error() (and friends) #2014

Merged
merged 4 commits into from
Nov 6, 2024

Conversation

hadley
Copy link
Member

@hadley hadley commented Nov 5, 2024

Fixes #1932. Fixes #1522

I'm hoping #2012 will fix the incorrect call in the error.

R/expect-condition.R Show resolved Hide resolved
R/expect-condition.R Show resolved Hide resolved
tests/testthat/_snaps/expect-condition.md Outdated Show resolved Hide resolved
tests/testthat/_snaps/expect-condition.md Outdated Show resolved Hide resolved
@hadley hadley merged commit 5a8200a into main Nov 6, 2024
13 checks passed
@hadley hadley deleted the better-condition-dots-checking branch November 6, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants