Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance #59

Closed
wants to merge 3 commits into from
Closed

Conformance #59

wants to merge 3 commits into from

Conversation

cholmes
Copy link
Collaborator

@cholmes cholmes commented Nov 13, 2020

Related Issue(s): #58 #27

Proposed Changes:

  1. Add conformance classes

PR Checklist:

  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.
  • API only: I have run npm run generate-all to update the generated OpenAPI files.

@cholmes
Copy link
Collaborator Author

cholmes commented Nov 13, 2020

@m-mohr - Ok, I'm still working through this, but was curious on feedback, as I don't think I have it right.

I've got the three conformance classes as you laid them out. But I said STAC Collections 'depends' on OGC API - Features core. But I don't think that's right, since you don't fully implement 'core', since it has items and you don't?

I wanted to say a valid STAC is either /search or /collections. But that doesn't seem to work. So it's implement either STAC Collections or (STAC search or STAC Items)? Which seems a bit complicated to explain.

And then I'm also not sure how to handle / in STAC, where that fits in. We say it 'Extends / from OAFeat to return a full STAC catalog.'

It feels like the easy thing may be to just drop our notion that /search would be implemented without implementing OGC API - Features... We could tell people if they wanted to just have a single endpoint to put all their features under a single collections/collectionsId endpoint.

I'll keep working away on fleshing this out...

@cholmes
Copy link
Collaborator Author

cholmes commented Nov 13, 2020

Ah, interesting, looking at https://earthengine.openeo.org/v1.0 I see that you do have conformance/ and it says you implement http://www.opengis.net/spec/ogcapi-features-1/1.0/conf/core. So I guess we could say STAC Collections depends on core, and then STAC Items would depend on GeoJSON.

Hrm, though it looks like you don't actually implement the /service-desc endpoint.

Looking at all the OGC requirements again does make me want to be able to offer something simpler - like just the /search/ endpoint and /conformance with a hardcoded value. Or /collections without more overhead.

Perhaps we have a stac-core that is the landing page (stac catalog and conformance/ (borrowed from / compatible to OAFeat) and collections/ ? With /search optional, and you can use the collectionId's to limit your search, but you don't have to implement collections/{id}/items for all collections - that'd be the stac-items class?

@cholmes cholmes closed this Nov 13, 2020
@cholmes cholmes deleted the conformance branch November 13, 2020 20:55
@cholmes
Copy link
Collaborator Author

cholmes commented Nov 13, 2020

this was based on the wrong branch, just going to redo this whole PR / branch.

@cholmes
Copy link
Collaborator Author

cholmes commented Nov 13, 2020

Replaced by #60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant