Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #430 add pkjson.dump_str and log pkunit case_dir #431

Merged
merged 4 commits into from
Jan 12, 2024
Merged

Fix #430 add pkjson.dump_str and log pkunit case_dir #431

merged 4 commits into from
Jan 12, 2024

Conversation

robnagler
Copy link
Member

  • Fix github_test to use new structure of github._TEST_REPOS

Benbenbenin0
Benbenbenin0 approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@Benbenbenin0 Benbenbenin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, had some clarifying questions.

tests/pkcli/github_test.py Show resolved Hide resolved
pykern/pkjson.py Show resolved Hide resolved
tests/pkcli/github_test.py Show resolved Hide resolved
@robnagler robnagler merged commit 7814806 into master Jan 12, 2024
2 checks passed
@robnagler robnagler deleted the 430-misc branch January 12, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benbenbenin0 Benbenbenin0 Benbenbenin0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robnagler @Benbenbenin0