Fix #529: Don't keep reference to tornado.httpclient.AsyncHTTPClient #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By keeping a reference to AsyncHTTPClient in self._client it causes sockets opened by the client to never be freed. Eventually, we run out of file descriptors. Writing the code this way w/o self._client prevents that from happening. This is a stop gap until we can fix the underlying bug.
|
@moellep please test with the slactwin code to confirm you see the socket growth issue resolved. |
moellep
approved these changes
Oct 3, 2024
robnagler
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By keeping a reference to AsyncHTTPClient in self._client it causes sockets opened by the client to never be freed. Eventually, we run out of file descriptors. Writing the code this way w/o self._client prevents that from happening. This is a stop gap until we can fix the underlying bug.