VMS build update #474
Open
VMS build update #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI test that failed was freebsd 13.2, and the relevant error was: pkg: No packages available to install matching 'openssl30' have been found in the repositoriesso it never actually got set up to build much less run a test. Sounds like that combination needs to be taken out of the list. |
Makefile.PL was initializing MakeMaker's CCFLAGS argument to
$Config{ccflags}, then manually appending -D switches to it. That
is not portable since not all compilers use that syntax for defines.
Luckily, MakeMaker knows how to parse compiler flags and inject
defines passed in -D format via its DEFINE argument. So use DEFINE
instead of CCFLAGS.
This test was failing on VMS because list assignment to %ENV is not allowed. So just override the slice of %ENV that the test is concerned with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.