Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DUMMY PULL REQUEST - testing github action. #1037

Closed
wants to merge 19 commits into from

Conversation

les-sheppard
Copy link
Contributor

Important

  • Please read our Contributing Guidelines before opening a PR.
  • Before creating your PR, please ensure you read the branching strategy. The end result after completing the merge actions should be that main <= release/XXX <= develop, where XXX is the latest released protocol version. This ensures that we minimise merge conflicts, and that work doesn't go missing.
  • As per the branching strategy, you must ensure you select the correct base branch, both for branching from, and in the PR UI above. The following process can be used to decide the base branch:
    • For code changes which can wait until the next protocol update to be released, use develop. This should be the default for code changes.
    • For code changes which need to go out as a fully-interoperable update to the node at the current protocol version, use release/XXX.
      • Such changes must be tested and reviewed more carefully to mitigate the risk of regression.
      • Once the change is merged, it is the merger's responsibility to ensure release/XXX is merged into the develop branch.
    • For github workflow changes, use main.
      • Once the change is merged, it is the merger's responsibility to ensure main is merged into both release/XXX and develop, so that the changes also apply to hotfixes, and to current development.
    • For changes to README files, use main.
      • Once the change is merged, it is the merger's responsibility to ensure main is merged into both release/XXX and develop, so that the changes also apply on these branches.

Please remove this section once you confirm you follow its guidance.

Summary

Testing

Copy link

Phylum Report Link

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.7%. Comparing base (b8f3151) to head (c9dc746).
Report is 13 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             develop   #1037   +/-   ##
=========================================
  Coverage       40.7%   40.7%           
- Complexity      4624    4625    +1     
=========================================
  Files           1892    1892           
  Lines          57516   57510    -6     
  Branches        1527    1527           
=========================================
- Hits           23415   23414    -1     
- Misses         33618   33619    +1     
+ Partials         483     477    -6     
Flag Coverage Δ
rust 40.7% <100.0%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...m/radixdlt/environment/rx/RxEnvironmentModule.java 79.6% <100.0%> (-0.2%) ⬇️
...om/radixdlt/messaging/core/MessageCentralImpl.java 57.1% <ø> (ø)
...main/java/com/radixdlt/rev2/REv2StateComputer.java 97.3% <100.0%> (+<0.1%) ⬆️

... and 4 files with indirect coverage changes

Copy link

github-actions bot commented Nov 29, 2024

Docker tags
docker.io/radixdlt/private-babylon-node:pr-1037
docker.io/radixdlt/private-babylon-node:62dce0d8c6
docker.io/radixdlt/private-babylon-node:sha-62dce0d

@radixbot
Copy link
Contributor

test comment

@radixbot
Copy link
Contributor

radixbot commented Dec 1, 2024

test comment

@radixbot
Copy link
Contributor

radixbot commented Dec 1, 2024

test comment 2

@radixbot
Copy link
Contributor

radixbot commented Dec 2, 2024

test comment

@radixbot
Copy link
Contributor

Comment added from test harness. 1733836576161

@radixbot
Copy link
Contributor

Comment added from test harness. 1733904793393

@radixbot
Copy link
Contributor

Comment added from test harness. 1733916296353

@radixbot
Copy link
Contributor

Comment added from test harness. 1733932099570

@radixbot
Copy link
Contributor

test

@radixbot
Copy link
Contributor

2024-12-12 11:51:42.512692

@radixbot
Copy link
Contributor

2024-12-12 11:53:44.219344 Benchmark dashboard Node dashboard Node JVM dashboard Node Logs

@radixbot
Copy link
Contributor

2024-12-12 11:56:29.376412



Benchmark dashboard
Node dashboard
Node JVM dashboard
Node Logs

@radixbot
Copy link
Contributor

##Benchmark summary 2024-12-12 11:58:07.164593


Benchmark dashboard
Node dashboard
Node JVM dashboard
Node Logs

@radixbot
Copy link
Contributor

Benchmark summary 2024-12-12 11:59:36




[Benchmark dashboard](https://radixdlt.grafana.net/d/de5bv0io3nif4b/node-ci-throughput-draft?orgId=1&+from=1734004773000&to=1734004776000&orgId=1)
[Node dashboard](https://radixdlt.grafana.net/d/MbAvJgT4z2/babylon-ephemeral-network?var-network=ephemeral-nw-node-benchmark-284&var-rate_interval=1m&var-node=All&from=1734004773000&to=1734004776000&orgId=1)
[Node JVM dashboard](https://radixdlt.grafana.net/d/chanjarster-jvm-dashboard-ephemeral/ephemeral-environment-babylon-node-jvm-dashboard?var-network=ephemeral-nw-node-benchmark-284&var-rate_interval=1m&var-node=All&from=1734004773000&to=1734004776000&orgId=1)
[Node Logs](https://radixdlt.grafana.net/explore?panes=%7B%22xPp%22:%7B%22datasource%22:%220xGA6JT4z%22,%22queries%22:%5B%7B%22refId%22:%22A%22,%22expr%22:%22%7Bnamespace%3D%5C%22ephemeral-nw-node-benchmark-284%5C%22,%20instance%3D%5C%22node0%5C%22%7D%20%7C%3D%20%60%60%22,%22queryType%22:%22range%22,%22datasource%22:%7B%22type%22:%22loki%22,%22uid%22:%220xGA6JT4z%22%7D,%22editorMode%22:%22builder%22,%22maxLines%22:5000%7D%5D,%22range%22:%7B%22from%22:%221734004773000%22,%22to%22:%221734004776000%22%7D%7D%7D&schemaVersion=1&orgId=1)

@radixbot
Copy link
Contributor

Benchmark summary 2024-12-12 12:00:35


Benchmark dashboard
Node dashboard
Node JVM dashboard
Node Logs

@radixbot
Copy link
Contributor

Benchmark summary 2024-12-12 12:03:00



Benchmark dashboard
Node dashboard
Node JVM dashboard
Node Logs

@radixbot
Copy link
Contributor

Benchmark summary 2024-12-12 12:06:14



Benchmark dashboard
Node dashboard
Node JVM dashboard
Node Logs

@radixbot
Copy link
Contributor

Benchmark summary 2024-12-12 13:30:09

Test case: xrd_transfer, TPS: 198
Test case: radquest, TPS: 73


Benchmark dashboard
Node dashboard
Node JVM dashboard
Node Logs

@les-sheppard les-sheppard deleted the pro-74-run-node-ci-benchmark-tests branch December 12, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants