Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't pull compose images #88

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't pull compose images #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/buildkite/config/rake_command.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ def rake(dir = "", task = "test", service: "default", pre_steps: [], &block)
plugin :docker_compose, {
"env" => %w[PRE_STEPS RACK],
"run" => service,
"pull" => service,
"config" => ".buildkite/docker-compose.yml",
"shell" => ["runner", dir],
}
Expand Down
18 changes: 0 additions & 18 deletions test/buildkite_config/test_rake_command.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ def test_command
{ "docker-compose#v1.0" =>
{ "env" => ["PRE_STEPS", "RACK"],
"run" => "default",
"pull" => "default",
"config" => ".buildkite/docker-compose.yml",
"shell" => ["runner", "test"] } }] }] }
assert_equal expected, pipeline.to_h
Expand Down Expand Up @@ -100,7 +99,6 @@ def test_default_task
{ "docker-compose#v1.0" =>
{ "env" => ["PRE_STEPS", "RACK"],
"run" => "default",
"pull" => "default",
"config" => ".buildkite/docker-compose.yml",
"shell" => ["runner", "activerecord"] } }] }] }
assert_equal expected, pipeline.to_h
Expand Down Expand Up @@ -131,7 +129,6 @@ def test_multiple
{ "docker-compose#v1.0" =>
{ "env" => ["PRE_STEPS", "RACK"],
"run" => "default",
"pull" => "default",
"config" => ".buildkite/docker-compose.yml",
"shell" => ["runner", "first"] } }] },
{ "label" => "second all (3.2)",
Expand All @@ -147,7 +144,6 @@ def test_multiple
{ "docker-compose#v1.0" =>
{ "env" => ["PRE_STEPS", "RACK"],
"run" => "default",
"pull" => "default",
"config" => ".buildkite/docker-compose.yml",
"shell" => ["runner", "second"] } }] }] }
assert_equal expected, pipeline.to_h
Expand Down Expand Up @@ -177,7 +173,6 @@ def test_docker_compose_plugin
{ "docker-compose#v1.0" =>
{ "env" => ["PRE_STEPS", "RACK"],
"run" => "myservice",
"pull" => "myservice",
"config" => ".buildkite/docker-compose.yml",
"shell" => ["runner", "subdirectory"] } }] }] }
assert_equal expected, pipeline.to_h
Expand Down Expand Up @@ -208,7 +203,6 @@ def test_env_yjit
{ "docker-compose#v1.0" =>
{ "env" => ["PRE_STEPS", "RACK"],
"run" => "default",
"pull" => "default",
"config" => ".buildkite/docker-compose.yml",
"shell" => ["runner", ""] } }] }] }
assert_equal expected, pipeline.to_h
Expand Down Expand Up @@ -240,7 +234,6 @@ def test_env_pre_steps
{ "docker-compose#v1.0" =>
{ "env" => ["PRE_STEPS", "RACK"],
"run" => "default",
"pull" => "default",
"config" => ".buildkite/docker-compose.yml",
"shell" => ["runner", ""] } }] }] }
assert_equal expected, pipeline.to_h
Expand Down Expand Up @@ -273,7 +266,6 @@ def test_agents
{ "docker-compose#v1.0" =>
{ "env" => ["PRE_STEPS", "RACK"],
"run" => "default",
"pull" => "default",
"config" => ".buildkite/docker-compose.yml",
"shell" => ["runner", ""] } }] }] }
assert_equal expected, pipeline.to_h
Expand Down Expand Up @@ -306,7 +298,6 @@ def test_artifact_paths
{ "docker-compose#v1.0" =>
{ "env" => ["PRE_STEPS", "RACK"],
"run" => "default",
"pull" => "default",
"config" => ".buildkite/docker-compose.yml",
"shell" => ["runner", ""] } }] }] }
assert_equal expected, pipeline.to_h
Expand Down Expand Up @@ -342,7 +333,6 @@ def test_automatic_retry_on
{ "docker-compose#v1.0" =>
{ "env" => ["PRE_STEPS", "RACK"],
"run" => "default",
"pull" => "default",
"config" => ".buildkite/docker-compose.yml",
"shell" => ["runner", ""] } }] }] }
assert_equal expected, pipeline.to_h
Expand Down Expand Up @@ -375,7 +365,6 @@ def test_timeout_in_minutes
{ "docker-compose#v1.0" =>
{ "env" => ["PRE_STEPS", "RACK"],
"run" => "default",
"pull" => "default",
"config" => ".buildkite/docker-compose.yml",
"shell" => ["runner", ""] } }] }] }
assert_equal expected, pipeline.to_h
Expand Down Expand Up @@ -409,7 +398,6 @@ def test_soft_fail
{ "docker-compose#v1.0" =>
{ "env" => ["PRE_STEPS", "RACK"],
"run" => "default",
"pull" => "default",
"config" => ".buildkite/docker-compose.yml",
"shell" => ["runner", ""] } }] }] }
assert_equal expected, pipeline.to_h
Expand Down Expand Up @@ -442,7 +430,6 @@ def test_soft_fail_ruby
{ "docker-compose#v1.0" =>
{ "env" => ["PRE_STEPS", "RACK"],
"run" => "default",
"pull" => "default",
"config" => ".buildkite/docker-compose.yml",
"shell" => ["runner", ""] } }] }] }
assert_equal expected, pipeline.to_h
Expand Down Expand Up @@ -475,7 +462,6 @@ def test_rake_with_block
{ "docker-compose#v1.0" =>
{ "env" => ["PRE_STEPS", "RACK"],
"run" => "default",
"pull" => "default",
"config" => ".buildkite/docker-compose.yml",
"shell" => ["runner", "test"] } }] }] }
assert_equal expected, pipeline.to_h
Expand Down Expand Up @@ -505,7 +491,6 @@ def test_rake_mysql_image_and_task_rails
{ "docker-compose#v1.0" =>
{ "env" => ["PRE_STEPS", "RACK"],
"run" => "default",
"pull" => "default",
"config" => ".buildkite/docker-compose.yml",
"shell" => ["runner", "activerecord"] } }] }] }
assert_equal expected, pipeline.to_h
Expand Down Expand Up @@ -537,7 +522,6 @@ def test_rake_mysql_image_and_task_rails_5_x
{ "docker-compose#v1.0" =>
{ "env" => ["PRE_STEPS", "RACK"],
"run" => "mysqldb",
"pull" => "mysqldb",
"config" => ".buildkite/docker-compose.yml",
"shell" => ["runner", "activerecord"] } }] }] }
assert_equal expected, pipeline.to_h
Expand Down Expand Up @@ -569,7 +553,6 @@ def test_rake_mysql_image_and_task_rails_4_x
{ "docker-compose#v1.0" =>
{ "env" => ["PRE_STEPS", "RACK"],
"run" => "mysqldb",
"pull" => "mysqldb",
"config" => ".buildkite/docker-compose.yml",
"shell" => ["runner", "activerecord"] } }] }] }
assert_equal expected, pipeline.to_h
Expand Down Expand Up @@ -601,7 +584,6 @@ def test_rake_postgres_image_and_task_rails_5_1
{ "docker-compose#v1.0" =>
{ "env" => ["PRE_STEPS", "RACK"],
"run" => "postgresdb",
"pull" => "postgresdb",
"config" => ".buildkite/docker-compose.yml",
"shell" => ["runner", "activerecord"] } }] }] }
assert_equal expected, pipeline.to_h
Expand Down