Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop connecting to an application by default in the console #182

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

rosa
Copy link
Member

@rosa rosa commented Oct 29, 2024

This will mess up enqueuing jobs from the console when using multiple adapters because of being in the middle of a migration, and only configuring one of them for Mission Control (eg. migrating from Sidekiq to Solid Queue). It's also not necessary because if we don't have a current server set, we just don't call activating and rely on the queue adapter configured for the job we want to enqueue (which might be per-job or the one set globally as config.active_job.queue_adapter).

Fixes #174

This will mess up enqueuing jobs from the console when using multiple
adapters because of being in the middle of a migration, and only
configuring one of them for Mission Control (eg. migrating from Sidekiq
to Solid Queue).
@rosa rosa merged commit 39ace57 into main Oct 29, 2024
10 checks passed
@rosa rosa deleted the fix-default-connection branch October 29, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect QueueAdapter used in console
1 participant