Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix ambiguous OID prefix canonical name test cases #313

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

cpb
Copy link

@cpb cpb commented Sep 25, 2024

When submitting this PR:

I found that there were 2 tests failing in main.

I observed that other simple mapping PRs had unrelated failures:

I'm proposing:

  1. Clarifying the ambiguous OID case from the Rails checkout is stale failure case
  2. Disambiguate two assert_contributor_names cases by using the full SHA

Copy link
Author

@cpb cpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fxn Thanks for chatting with me near the swag/coat check counter at Rails World between talks. I agree with maintaining the aesthetics of the test and PR, so have shorted the SHAs to achieve the disambiguation for these two cases.

I'll follow up with tooling to support reducing the effort to resolve other such failures, as we discussed.

Thank you for your time, I hope you had a great time at Rails World!

test/credits/canonical_names_test.rb Outdated Show resolved Hide resolved
test/credits/canonical_names_test.rb Outdated Show resolved Hide resolved
@cpb
Copy link
Author

cpb commented Oct 8, 2024

@fxn Thanks for chatting with me near the swag/coat check counter at Rails World between talks. I agree with maintaining the aesthetics of the test and PR, so have shorted the SHAs to achieve the disambiguation for these two cases.

I'll follow up with tooling to support reducing the effort to resolve other such failures, as we discussed.

Thank you for your time, I hope you had a great time at Rails World!

The changes in this PR are made redundant by the tooling and changes introduced in this PR:

@fxn
Copy link
Member

fxn commented Oct 8, 2024

Hi man! Thanks a lot for this. I have several things in my plate, but I'll eventually work on your proposal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants