Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to silence the polling logs #37

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Add option to silence the polling logs #37

merged 2 commits into from
Nov 13, 2023

Conversation

djmb
Copy link
Contributor

@djmb djmb commented Nov 7, 2023

The polling logs are noisy in debug mode, so provide an option to silence them.

cc @rosa

The polling logs are noisy in debug mode, so provide an option to
silence them.
@rosa
Copy link
Member

rosa commented Nov 7, 2023

Thank you @djmb! I just have a question: why did you go for a per-worker option instead of a global config option? Do you think people will want to see some workers but not others?

Also: logging is super rudimentary still 🙈 I have a pending to-do to tidy it up and add proper instrumentation, and I got started but had to park it to work on other things. Current logging has been a lot for me to debug issues, so feel free to remove/change whatever you need from that.

@djmb
Copy link
Contributor Author

djmb commented Nov 8, 2023

Thank you @djmb! I just have a question: why did you go for a per-worker option instead of a global config option? Do you think people will want to see some workers but not others?

@rosa - no good reason, I just hadn't considered that! It's a much better idea, so I've changed it to do that here

Copy link
Member

@rosa rosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👏 Thank you so much, @djmb!

@djmb djmb merged commit 11cdc67 into main Nov 13, 2023
4 checks passed
@djmb djmb deleted the silence-polling branch November 13, 2023 12:01
@djmb djmb mentioned this pull request Nov 14, 2023
hms pushed a commit to ikyn-inc/solid_queue that referenced this pull request Aug 5, 2024
Introduce the dispatch action to blocked jobs

Closes rails#37

Signed-off-by: Lex Cao <lexcao@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants