Remove support for prefix matching in queues assigned to a worker #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would generate queries like ``` WHERE `solid_queue_ready_executions.queue_name` LIKE 'prefix%' ``` that aren't performant enough due to the sorting by priority, so we've decided not to support these for now. Thanks to @djmb for the assistance with this.
rosa
force-pushed
the
remove-prefix-wildcard-support
branch
from
85abb8e
to
83362bd
Compare
rosa
added a commit
that referenced
this pull request
Dec 1, 2023
This was removed in #45, as the resulting queries for polling using `queue_name LIKE 'something%'` were very slow as they prevented MySQL from using an index for ordering. The idea after removing that was to support namespaces so we could combine a namespace with a "*" for queue names, to have support for a single prefix. However, namespaces felt a too big of a change just to accomodate for our staging and beta setups, so I've brought this back, but this time with a different implementation, based on fetching the list of queue names relevant for polling, filtering there with the prefix. This query is very fast because it can use an existing index starting with queue_name and apply the Loose Index Scan technique to examine as many rows as distinct values there are.
rosa
added a commit
that referenced
this pull request
Dec 1, 2023
This was removed in #45, as the resulting queries for polling using `queue_name LIKE 'something%'` were very slow as they prevented MySQL from using an index for ordering. The idea after removing that was to support namespaces so we could combine a namespace with a "*" for queue names, to have support for a single prefix. However, namespaces felt a too big of a change just to accomodate for our staging and beta setups, so I've brought this back, but this time with a different implementation, based on fetching the list of queue names relevant for polling, filtering there with the prefix. This query is very fast because it can use an existing index starting with queue_name and apply the Loose Index Scan technique to examine as many rows as distinct values there are.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would generate queries like
that aren't performant enough due to the sorting by priority, so we've decided not to support these for now.
Thanks to @djmb for the assistance with this.