Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In url() prevent relative path from being converted to root absolute path #511

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sega100500
Copy link

Prevent non-digest (not assets pipeline) relative path from being converted to root absolute path. Prevent convert url() in attached third-party css-styles libraries.

…e path

Prevent non-digest  (not assets pipeline) relative path from being converted to root absolute path. Prevent convert url() in attached thrid-party css-styles libraries.
@shuyahonda
Copy link

@Sega100500
I'm using ckeditor gem and meet the same problem.
This fix will solve the problem.

@huda-kh
Copy link

huda-kh commented Aug 16, 2024

@Sega100500 I'm using ckeditor gem and meet the same problem. This fix will solve the problem.

Same here.. what have you done while waiting for this fix?

@Sega100500
Copy link
Author

@huda-kh
I suggested a very simple solution for fix this bug - just 2 lines of code. My fix failed the some tests and was successfully ignored.
It is not difficult for me to manually fix the gem code after installation.

If Rails developers do not care about their product (and included to it gems) - they continue to ignore this bug.

@huda-kh
Copy link

huda-kh commented Aug 16, 2024 via email

@Sega100500
Copy link
Author

Sega100500 commented Aug 16, 2024

@huda-kh
Yes, agree - using config.assets.resolve_assets_in_css_urls is also very good solution. If it works correctly for you in all cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants