Enable arm64 based images for calico, multus and harvester #5154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandond
approved these changes
Dec 21, 2023
thomasferrandiz
approved these changes
Dec 22, 2023
manuelbuil
approved these changes
Jan 2, 2024
Also removes deprecated `cilium-etcd-operator` Signed-off-by: Michael Fritch <mfritch@suse.com>
mgfritch
force-pushed
the
enable-cilium-arm64-pkg
branch
from
af8845f
to
5ca1779
Compare
`rancher/image-mirror` is unable to mirror arm64 builds of these images Issue: rancher#5260 Signed-off-by: Michael Fritch <mfritch@suse.com>
brandond
requested changes
Jan 12, 2024
There was a problem hiding this comment.
nit: this is also enabling arm64 for calico, multus, vsphere, and harvester. Either make sure that those all exist, or keep them excluded from this arch.
Also, if you keep those included, update the PR title and description to make it clear that we're doing more than just cilium here.
mgfritch
changed the title
mgfritch
changed the title
mgfritch
changed the title
brandond
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables packaging of
arm64images for calico, multus and harvester.Also removes the deprecated
cilium-etcd-operatorLinked issues:
cloud-provider-vsphereimages fail to build on an arm64 platform #5260