Overhaul AutoLayout Alignment property #95
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This branch is running in CodeSandbox. Use the links below to review this PR faster. |
|
Demo App Preview: https://d11mwnosflssyy.cloudfront.net/ |
Code Coverage ReportCoverage after merging AutoLayout-alignment-overhaul into main
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 05b2c34. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
1 task
nkanigsberg
force-pushed
the
AutoLayout-alignment-overhaul
branch
from
3beeb3c
to
05b2c34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 Work In Progress 🚧
TODO
align-itemsandjustify-contentproperties), this presents a problem. For the time being I've just added an escape where the alignment property isn't actually computed if passed anything buthorizontalorvertical, which obviously is not a good long-term solution.library/foundations/generated/design-tokens.constants.ts, but containing values. From this we can compute the appropriate styles at each breakpoint... but this would require listening to the browser size.alignmentproperty has been used to make sure they are working correctly with the new schemaScreenshots