Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallets): add evm to phantom #349

Closed
wants to merge 2 commits into from

Conversation

nikaaru
Copy link
Member

@nikaaru nikaaru commented Aug 30, 2023

No description provided.

@nikaaru nikaaru changed the title wallet: add evm to phantom feat(wallets): add evm to phantom Sep 2, 2023
Copy link
Member

@RanGojo RanGojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When user uses a Solana only account in phantom, he will face with this error:
Unsupported Account. App is trying to connect to an EVM network that this account doesn't support.
And he could not proceed anymore. Please check if we could have a solution to support this case as well.

I have asked this question in phantom github:
https://github.com/orgs/phantom/discussions/95

instances.set(Networks.ETHEREUM, ethereum);
}

if (solana && phantom.isPhantom) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be solana.isPhantom?

@yeager-eren
Copy link
Collaborator

When user uses a Solana only account in phantom, he will face with this error: Unsupported Account. App is trying to connect to an EVM network that this account doesn't support. And he could not proceed anymore. Please check if we could have a solution to support this case as well.

I have asked this question in phantom github: https://github.com/orgs/phantom/discussions/95

The problem is a wallet can be Solana-only, and if it is, Phantom is injecting both ethereum and solana. I tried to find a workaround for detecting wallet's available chains, I couldn't. So it's not possible to avoid that popup.

Here is the conclusion:

  1. Showing a modal to user select what really wants to connect(Solana, EVM or Both) so it clearly communicate and user will choose the right one.
  2. If phantom's default setting is to create Solana + EVM for its users, we can do a tradeoff and accept this risk some users will see this error if they have only Solana account on phantom.

@yeager-eren
Copy link
Collaborator

Closing this PR.
An initial version is implemented in this PR: #623 (commit)
And it will be available to users when we merged that PR.

@yeager-eren yeager-eren closed this Apr 3, 2024
@RanGojo RanGojo deleted the feat/rf-820-add-evm-to-phantom branch August 20, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants