-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wallets): add evm to phantom #349
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When user uses a Solana only account in phantom, he will face with this error:
Unsupported Account. App is trying to connect to an EVM network that this account doesn't support.
And he could not proceed anymore. Please check if we could have a solution to support this case as well.
I have asked this question in phantom github:
https://github.com/orgs/phantom/discussions/95
instances.set(Networks.ETHEREUM, ethereum); | ||
} | ||
|
||
if (solana && phantom.isPhantom) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be solana.isPhantom
?
The problem is a wallet can be Solana-only, and if it is, Phantom is injecting both Here is the conclusion:
|
No description provided.