chore: change Namespace enum to stirng #964
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Using a single source of truth for Namespace.
We need to use a single type for both legacy and hub implementation. To make it more general and don't needing to always keeping the namespace updated by what Rango currently support, I changed it to
string
, instead of enum. To have namespace suggestion while coding, I used a trick to suggest our supported namespaces alongside the fact that it can be any string.Fixes # (issue)
How did you test this change?
It should be compiled correctly, shouldn't affect the functionality of working with wallets.
Checklist: