Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a level filter #176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

joshuasmall
Copy link

No description provided.

@rap2hpoutre
Copy link
Owner

Hi, thank you for your contribution. Could you please explain the purpose (and the design choices) of this suggestion? I'm not sure to understand what problem it solves and what it does by reading the code.

@joshuasmall
Copy link
Author

Hi,
It adds a dropdown allowing you to filter out the log level, I found it useful to view only certain log levels, i.e. errors.

I modified the DataTable dom option here as it allowed me to render the select on the same line as the entries dropdown and the search box.

screenshot 2018-10-04 at 12 50 51

@247software-sanket-gandhi

Hey @rap2hpoutre
Can we merge this PR? This is very useful for filtering the logs.

@bethuxs
Copy link

bethuxs commented Aug 30, 2019

Please merge this commit, it's useful

@galdazbiz
Copy link

@joshuasmall @rap2hpoutre Please merge this, It's a very useful commit!

@josevavia
Copy link

Please merge this commit!

@tronne
Copy link

tronne commented Dec 27, 2019

Guys, don't loose your time asking for a merge, its never gonna arrive. Just put error in the search input and magic👍

@josevavia
Copy link

josevavia commented Dec 27, 2019

Guys, don't loose your time asking for a merge, its never gonna arrive. Just put error in the search input and magic

Depending on the messages in the log, this solution does not work... Imagine a message on level "info" with the text "Database started with no errors". The message will appear when searching the "error" string.

That is my particular case, I log every request to my API in debug level, and every request has the word "error" in the url...

@tronne
Copy link

tronne commented Dec 27, 2019

Good luck then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants