New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added assets to local folder instead of CDN #244

Open

abdurrahmanriyad wants to merge 1 commit into rap2hpoutre:master from abdurrahmanriyad:master

abdurrahmanriyad commented Sep 26, 2020

CDN links of bootstrap and jquery are restricted in china so I moved them local assets.
Also, update readme to publish assets


          Added assets to local folder instead of cdn

bfa282c

abdurrahmanriyad mentioned this pull request

Two Javascript links are not accessible in China #242

Open

Owner

rap2hpoutre commented May 4, 2022

Hi @abdurrahmanriyad thank you for contributing. I guess it's a good move, thank you! Still, I have some questions:

Does this mean that user will have to run one more command? If so that could be considered an issue because I want to keep this lib super simple. In other hand, making it unavailable in China is an issue too! Do you think we could maintain both? (ie: nothing to run, just work as usual for user not in China and one more command for people in China)
I can't see the readme update
Do we have to change the blade files too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet