Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated deprecated functions #167

Merged
merged 2 commits into from
Apr 7, 2024
Merged

Conversation

sjg2203
Copy link
Contributor

@sjg2203 sjg2203 commented Apr 1, 2024

Updated deprecated functions:

  • Series.replace() to Series.cat.rename_categories()
  • pd.Timedelta('S') to pd.Timedelta('s')

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.90%. Comparing base (c734753) to head (553814a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #167   +/-   ##
=======================================
  Coverage   83.90%   83.90%           
=======================================
  Files          24       24           
  Lines        3498     3498           
=======================================
  Hits         2935     2935           
  Misses        563      563           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raphaelvallat
Copy link
Owner

Can you please revert the black formatting changes? Can you please also say more about the deprecation, and whether this requires to bump the minimal pandas version? Thanks

sjg2203 added 2 commits April 5, 2024 14:35
…gories()

Signed-off-by: S.J. Guillot <58807831+sjg2203@users.noreply.github.com>
…preferred over 'S'

Signed-off-by: S.J. Guillot <58807831+sjg2203@users.noreply.github.com>
@sjg2203 sjg2203 reopened this Apr 5, 2024
@sjg2203
Copy link
Contributor Author

sjg2203 commented Apr 5, 2024

Series.replace() was replaced in Pandas 2.1.0 in favor of Series.cat.rename_categories()
pd.Timedelta('S') was replaced in Pandas 2.2.0 where H, T, S, L, U and N were replaced by h, min, s, ms, us, and ns
It might be wise to bump Pandas version to >=2.2.0

Copy link
Owner

@raphaelvallat raphaelvallat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, thanks!

@raphaelvallat raphaelvallat merged commit 5200696 into raphaelvallat:master Apr 7, 2024
28 checks passed
@raphaelvallat
Copy link
Owner

I'll keep the current dependencies as is for now, and might bump pandas in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants