Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Change components js to typescript #7

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jackelinepao
Copy link

@jackelinepao jackelinepao commented Jul 16, 2024

Description

  • Change js components to ts
  • Add types and interfaces in components

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Code style update (formatting, renaming, css, typography, colors)
  • API Schema update
  • New feature (non-breaking change which adds functionality)
  • Breaking change (I have changes that require further review and merge carefuly with exiting tickets)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly the atomic componentes
  • My changes generate no new warnings nor console error
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have update the yarn schema with the latest on backend
  • I have documented new feature in notion https://www.notion.so/ravndevelopment/Admin-Portal-a7f38c581fb6442ab58aae2f35fdb727

Video/Screenshots:

@jackelinepao jackelinepao changed the title Refactor: Refactor: Change components js to typescript Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant