Random fixes #34
Merged
Random fixes #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Section numbers in output were off by one because the generated document starte off with the preface as section number 1. By enabling pandoc's attributes extension, we can make the Preface section unnumbered. Thus the introduction becomes the first chapter, and the remaining chapters follow the numbering of the input files.
Pandoc does not care about input filenames, and thus the links to other files in the book do not work. What we can do is link to the autogenerated heading identifiers. This works even across multiple input files, because pandoc treats the input as a single concatenated document.
hmkemppainen
had a problem deploying
to
github-pages
GitHub Actions
Failure
hmkemppainen
force-pushed
the
random-fixes
branch
from
47ba3a3 to
b22a398
Compare
hmkemppainen
had a problem deploying
to
github-pages
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the section numbers in generated output did not match the text or input files. This is fixed by enabling pandoc attributes and making the preface unnumbered.
Also the internal links were all broken. Fixed by using header identifiers.
Note I couldn't get github to run the actions for me so I've only tested the pandoc changes locally with a version that may or may not match the version used on github.
There's still at least one broken link, chapter 12's matmul.k. I'll leave it to you to decide how to fix but I guess for pdf & epub users, simply using an absolute URL would work best.
I found a few more typos too.