-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add afterOpenChange prop #349
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
close #251 |
Codecov Report
@@ Coverage Diff @@
## master #349 +/- ##
=======================================
Coverage 98.73% 98.74%
=======================================
Files 7 7
Lines 158 159 +1
Branches 49 49
=======================================
+ Hits 156 157 +1
Misses 1 1
Partials 1 1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Co-authored-by: afc163 <afc163@gmail.com>
这块跑 prettier 改动还蛮大的,就暂时吧 prettier 管了; |
需要升级一下 father 了,用 lint-staged 就不会检查其他文件 |
好嘞,father 升级我另开个 pr 吧 |
rc-test 有自动升级脚本,father 4 去掉了内置的 husky,所以需要手动安装一下 |
大佬,我按照 re-menu 升级的 pr 和 father 升级指南看了下,目前还有问题,似乎还需要自己安装 husky 并且配置 pre-commit 才能提交,但是我看其他 rc 项目并没有做这些配置。 |
结合原 issue 下的提示,按照 rc-drawer 的 api 定义方式重新修改了下,还是 afterOpenChange 更合适。 |
相关 issue:
|
close ant-design/ant-design#40810
close #251